Commit 9f606179 authored Oct 19, 2017 by Quentin Monnet Committed by David S. Miller Oct 22, 2017

tools: bpftool: add `bpftool prog help` as real command i.r.t exit code



Make error messages and return codes more consistent. Specifically, make
`bpftool prog help` a real command, instead of printing usage by default
for a non-recognized "help" command. Output is the same, but this makes
bpftool return with a success value instead of an error.

Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1d84487e

tools/bpf/bpftool/prog.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -475,6 +475,7 @@ static int do_help(int argc, char **argv)

	static const struct cmd cmds[] = {		static const struct cmd cmds[] = {
	{ "show", do_show },		{ "show", do_show },
			{ "help", do_help },
	{ "dump", do_dump },		{ "dump", do_dump },
	{ "pin", do_pin },		{ "pin", do_pin },
	{ 0 }		{ 0 }

Admin message