Commit 9f4c1396 authored Oct 05, 2010 by Yinghai Lu Committed by H. Peter Anvin Oct 05, 2010

x86, memblock: Fix crashkernel allocation



Cai Qian found crashkernel is broken with the x86 memblock changes.

1. crashkernel=128M@32M always reported that range is used, even if
   the first kernel is small and does not usethat range

2. we always got following report when using "kexec -p"
	Could not find a free area of memory of a000 bytes...
	locate_hole failed

The root cause is that generic memblock_find_in_range() will try to
allocate from the top of the range, whereas the kexec code was written
assuming that allocation was always near the bottom and that it could
blindly extend memory upward.  Unfortunately the kexec code doesn't
have a system for requesting the range that it really needs, so this
is subject to probabilistic failures.

This patch hacks around the problem by limiting the target range
heuristically to below the traditional bzImage max range.  This number
is arbitrary and not always correct, and a much better result would be
obtained by having kexec communicate this number based on the kernel
header information and any appropriate command line options.

Reported-and-Bisected-by: CAI Qian <caiqian@redhat.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <4CABAF2A.5090501@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>

parent 7c996361

arch/x86/kernel/setup.c

+9 −4

Original line number	Diff line number	Diff line
		@@ -502,6 +502,7 @@ static inline unsigned long long get_total_mem(void)
		return total << PAGE_SHIFT;
		}

		#define DEFAULT_BZIMAGE_ADDR_MAX 0x37FFFFFF
		static void __init reserve_crashkernel(void)
		{
		unsigned long long total_mem;
		@@ -519,8 +520,12 @@ static void __init reserve_crashkernel(void)
		if (crash_base <= 0) {
		const unsigned long long alignment = 16<<20; /* 16M */

		crash_base = memblock_find_in_range(alignment, ULONG_MAX, crash_size,
		alignment);
		/*
		* kexec want bzImage is below DEFAULT_BZIMAGE_ADDR_MAX
		*/
		crash_base = memblock_find_in_range(alignment,
		DEFAULT_BZIMAGE_ADDR_MAX, crash_size, alignment);

		if (crash_base == MEMBLOCK_ERROR) {
		pr_info("crashkernel reservation failed - No suitable area found.\n");
		return;
		@@ -528,8 +533,8 @@ static void __init reserve_crashkernel(void)
		} else {
		unsigned long long start;

		start = memblock_find_in_range(crash_base, ULONG_MAX, crash_size,
		1<<20);
		start = memblock_find_in_range(crash_base,
		crash_base + crash_size, crash_size, 1<<20);
		if (start != crash_base) {
		pr_info("crashkernel reservation failed - memory is in use.\n");
		return;

Admin message