Commit 9f407840 authored Oct 15, 2010 by Dan Carpenter Committed by Greg Kroah-Hartman Oct 15, 2010

Staging: intel_sst: off by one bug



This should be >= instead of > or we go passed the end of the array.

Also the arrays are declared with size MAX_NUM_STREAMS.  This is the
only place that uses MAX_NUM_STREAMS_MFLD.  It seems like asking for
trouble to use two variables for the same information.  I've changed
everything to use MAX_NUM_STREAMS.

This bug isn't really harmful.  In the worst case, if you enabled
debugging then you would see a message.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 87b554a0

drivers/staging/intel_sst/intel_sst_fw_ipc.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -31,7 +31,6 @@
		*/

		#define MAX_NUM_STREAMS_MRST 3
		#define MAX_NUM_STREAMS_MFLD 6
		#define MAX_NUM_STREAMS 6
		#define MAX_DBG_RW_BYTES 80
		#define MAX_NUM_SCATTER_BUFFERS 8

drivers/staging/intel_sst/intel_sst_stream.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -45,7 +45,7 @@
		*/
		int sst_check_device_type(u32 device, u32 num_chan, u32 *pcm_slot)
		{
		if (device > MAX_NUM_STREAMS_MFLD) {
		if (device >= MAX_NUM_STREAMS) {
		pr_debug("sst: device type invalid %d\n", device);
		return -EINVAL;
		}

Admin message