Commit 9f354858 authored Apr 28, 2008 by Olof Johansson Committed by Linus Torvalds Apr 28, 2008

fatfs: fix build warning with 64k PAGE_SIZE



Annoying gcc warning:

fs/fat/inode.c: In function 'fat_fill_super':
fs/fat/inode.c:1222: warning: comparison is always false due to limited range of data type

Change it to compare with 4K instead of PAGE_CACHE_SIZE, as suggested
by OGAWA-san.

[FAT spec says: logical_sector_size should be 512, 1024, 2048 4096]
So, at least for now, we limit it to 4096.

Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0607fd02

fs/fat/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1226,7 +1226,7 @@ int fat_fill_super(struct super_block sb, void data, int silent,
		le16_to_cpu(get_unaligned((__le16 *)&b->sector_size));
		if (!is_power_of_2(logical_sector_size)
		\|\| (logical_sector_size < 512)
		\|\| (PAGE_CACHE_SIZE < logical_sector_size)) {
		\|\| (logical_sector_size > 4096)) {
		if (!silent)
		printk(KERN_ERR "FAT: bogus logical sector size %u\n",
		logical_sector_size);

Admin message