Commit 9f01a71c authored May 27, 2020 by Colin Ian King Committed by David S. Miller May 27, 2020

net: dsa: b53: remove redundant premature assignment to new_pvid



Variable new_pvid is being assigned with a value that is never read,
the following if statement updates new_pvid with a new value in both
of the if paths. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f96e9641

drivers/net/dsa/b53/b53_common.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1325,7 +1325,6 @@ int b53_vlan_filtering(struct dsa_switch *ds, int port, bool vlan_filtering)
		u16 pvid, new_pvid;

		b53_read16(dev, B53_VLAN_PAGE, B53_VLAN_PORT_DEF_TAG(port), &pvid);
		new_pvid = pvid;
		if (!vlan_filtering) {
		/* Filtering is currently enabled, use the default PVID since
		* the bridge does not expect tagging anymore

Admin message