Commit 9efab1ad authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Luca Coelho
Browse files

iwlwifi: remove fw_monitor module parameter



This module parameter is no longer useful now that other debug
infrastructure was added to iwlwifi.

Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200418110539.03bd49c3432b.Ie62047d3b364b19c8c3584ea37790220466f2a8d@changeid
parent 9dede812
Loading
Loading
Loading
Loading
+0 −4
Original line number Diff line number Diff line
@@ -1872,10 +1872,6 @@ module_param_named(power_level, iwlwifi_mod_params.power_level, int, 0444);
MODULE_PARM_DESC(power_level,
		 "default power save level (range from 1 - 5, default: 1)");

module_param_named(fw_monitor, iwlwifi_mod_params.fw_monitor, bool, 0444);
MODULE_PARM_DESC(fw_monitor,
		 "firmware monitor - to debug FW (default: false - needs lots of memory)");

module_param_named(disable_11ac, iwlwifi_mod_params.disable_11ac, bool, 0444);
MODULE_PARM_DESC(disable_11ac, "Disable VHT capabilities (default: false)");

+0 −2
Original line number Diff line number Diff line
@@ -115,7 +115,6 @@ enum iwl_uapsd_disable {
 * @nvm_file: specifies a external NVM file
 * @uapsd_disable: disable U-APSD, see &enum iwl_uapsd_disable, default =
 *	IWL_DISABLE_UAPSD_BSS | IWL_DISABLE_UAPSD_P2P_CLIENT
 * @fw_monitor: allow to use firmware monitor
 * @disable_11ac: disable VHT capabilities, default = false.
 * @remove_when_gone: remove an inaccessible device from the PCIe bus.
 * @enable_ini: enable new FW debug infratructure (INI TLVs)
@@ -135,7 +134,6 @@ struct iwl_mod_params {
	int antenna_coupling;
	char *nvm_file;
	u32 uapsd_disable;
	bool fw_monitor;
	bool disable_11ac;
	/**
	 * @disable_11ax: disable HE capabilities, default = false
+1 −14
Original line number Diff line number Diff line
@@ -1019,21 +1019,8 @@ static int iwl_pcie_load_given_ucode(struct iwl_trans *trans,
			return ret;
	}

	/* supported for 7000 only for the moment */
	if (iwlwifi_mod_params.fw_monitor &&
	    trans->trans_cfg->device_family == IWL_DEVICE_FAMILY_7000) {
		struct iwl_dram_data *fw_mon = &trans->dbg.fw_mon;

		iwl_pcie_alloc_fw_monitor(trans, 0);
		if (fw_mon->size) {
			iwl_write_prph(trans, MON_BUFF_BASE_ADDR,
				       fw_mon->physical >> 4);
			iwl_write_prph(trans, MON_BUFF_END_ADDR,
				       (fw_mon->physical + fw_mon->size) >> 4);
		}
	} else if (iwl_pcie_dbg_on(trans)) {
	if (iwl_pcie_dbg_on(trans))
		iwl_pcie_apply_destination(trans);
	}

	iwl_enable_interrupts(trans);