Commit 9edbcd22 authored by Sebastian Ott's avatar Sebastian Ott Committed by Bjorn Helgaas
Browse files

PCI: Remove pcibios_add_platform_entries() 

Remove pcibios_add_platform_entries().  Architecture-specific attributes
can be achieved by setting pdev->dev.groups.

Link: https://lkml.kernel.org/r/alpine.LFD.2.11.1404141101500.1529@denkbrett


Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ef4858c6

drivers/pci/pci-sysfs.c

+0 −10
Original line number Diff line number Diff line
@@ -1273,11 +1273,6 @@ static struct bin_attribute pcie_config_attr = { 
	.write = pci_write_config,

};



int __weak pcibios_add_platform_entries(struct pci_dev *dev)

{

	return 0;

}



static ssize_t reset_store(struct device *dev,

			   struct device_attribute *attr, const char *buf,

			   size_t count)
@@ -1393,11 +1388,6 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev) 
		pdev->rom_attr = attr;

	}



	/* add platform-specific attributes */

	retval = pcibios_add_platform_entries(pdev);

	if (retval)

		goto err_rom_file;



	/* add sysfs entries for various capabilities */

	retval = pci_create_capabilities_sysfs(pdev);

	if (retval)

include/linux/pci.h

+0 −1
Original line number Diff line number Diff line
@@ -1572,7 +1572,6 @@ extern unsigned long pci_hotplug_io_size; 
extern unsigned long pci_hotplug_mem_size;



/* Architecture-specific versions may override these (weak) */

int pcibios_add_platform_entries(struct pci_dev *dev);

void pcibios_disable_device(struct pci_dev *dev);

void pcibios_set_master(struct pci_dev *dev);

int pcibios_set_pcie_reset_state(struct pci_dev *dev,

CRA Git | Maintained and supported by SUSTech CRA and CCSE