Commit 9eb6f16d authored May 17, 2014 by Christian Engelmayer Committed by Greg Kroah-Hartman May 24, 2014

staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()



Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS
as long as not explicitly set. Thus initialize 'status' to FAIL, in order to
prevent undefined behaviour if going through the exit paths. Detected by
Coverity - CID 1077832.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e0c49319

drivers/staging/rtl8188eu/os_dep/usb_intf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -686,7 +686,7 @@ static void rtw_usb_if1_deinit(struct adapter *if1)
		static int rtw_drv_init(struct usb_interface pusb_intf, const struct usb_device_id pdid)
		{
		struct adapter *if1 = NULL;
		int status;
		int status = _FAIL;
		struct dvobj_priv *dvobj;

		RT_TRACE(_module_hci_intfs_c_, _drv_err_, ("+rtw_drv_init\n"));

Admin message