Commit 9eb13f65 authored Mar 23, 2016 by Sebastian Frias Committed by David S. Miller Mar 23, 2016

net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY



This removes the dependency on GPIOLIB for non faulty PHYs.

Indeed, without this patch, if GPIOLIB is not selected
devm_gpiod_get_optional() will return -ENOSYS and the driver probe
call will fail, regardless of the actual PHY hardware.

Out of the 3 PHYs supported by this driver (AT8030, AT8031, AT8035),
only AT8030 presents the issues that commit 13a56b44 ("net: phy:
at803x: Add support for hardware reset") attempts to work-around by
using a 'reset' GPIO line.

Hence, only AT8030 should depend on GPIOLIB operating properly.

Fixes: 13a56b44 ("net: phy: at803x: Add support for hardware reset")

Signed-off-by: Sebastian Frias <sf84@laposte.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d57019d1

drivers/net/phy/at803x.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -277,12 +277,16 @@ static int at803x_probe(struct phy_device *phydev)
		if (!priv)
		return -ENOMEM;

		if (phydev->drv->phy_id != ATH8030_PHY_ID)
		goto does_not_require_reset_workaround;

		gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
		if (IS_ERR(gpiod_reset))
		return PTR_ERR(gpiod_reset);

		priv->gpiod_reset = gpiod_reset;

		does_not_require_reset_workaround:
		phydev->priv = priv;

		return 0;

Admin message