Commit 9eaa903c authored Oct 30, 2017 by Nicolas Pitre Committed by Richard Weinberger Nov 13, 2017

mtd: implement mtd_get_unmapped_area() using the point method



The mtd->_point method is a superset of mtd->_get_unmapped_area.
Especially in the NOR flash case, the point method ensures the flash
memory is in array (data) mode and that it will stay that way which
is precisely what callers of mtd_get_unmapped_area() would expect.

Implement mtd_get_unmapped_area() in terms of mtd->_point now that all
drivers that provided a _get_unmapped_area method also have the _point
method implemented.

Signed-off-by: Nicolas Pitre <nico@linaro.org>
Reviewed-by: Richard Weinberger <richard@nod.at>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 55100cfa

drivers/mtd/mtdcore.c

+12 −5

Original line number	Diff line number	Diff line
		@@ -1022,11 +1022,18 @@ EXPORT_SYMBOL_GPL(mtd_unpoint);
		unsigned long mtd_get_unmapped_area(struct mtd_info *mtd, unsigned long len,
		unsigned long offset, unsigned long flags)
		{
		if (!mtd->_get_unmapped_area)
		return -EOPNOTSUPP;
		if (offset >= mtd->size \|\| len > mtd->size - offset)
		return -EINVAL;
		return mtd->_get_unmapped_area(mtd, len, offset, flags);
		size_t retlen;
		void *virt;
		int ret;

		ret = mtd_point(mtd, offset, len, &retlen, &virt, NULL);
		if (ret)
		return ret;
		if (retlen != len) {
		mtd_unpoint(mtd, offset, retlen);
		return -ENOSYS;
		}
		return (unsigned long)virt;
		}
		EXPORT_SYMBOL_GPL(mtd_get_unmapped_area);

Admin message