Commit 9e8c399a authored Sep 27, 2017 by Matt Redfearn Committed by James Hogan Nov 01, 2017

MIPS: SMP: Fix deadlock & online race

Commit 6f542ebe ("MIPS: Fix race on setting and getting
cpu_online_mask") effectively reverted commit 8f46cca1 ("MIPS: SMP:
Fix possibility of deadlock when bringing CPUs online") and thus has
reinstated the possibility of deadlock.

The commit was based on testing of kernel v4.4, where the CPU hotplug
core code issued a BUG() if the starting CPU is not marked online when
the boot CPU returns from __cpu_up. The commit fixes this race (in
v4.4), but re-introduces the deadlock situation.

As noted in the commit message, upstream differs in this area. Commit
8df3e07e ("cpu/hotplug: Let upcoming cpu bring itself fully up")
adds a completion event in the CPU hotplug core code, making this race
impossible. However, people were unhappy with relying on the core code
to do the right thing.

To address the issues both commits were trying to fix, add a second
completion event in the MIPS smp hotplug path. It removes the
possibility of a race, since the MIPS smp hotplug code now synchronises
both the boot and secondary CPUs before they return to the hotplug core
code. It also addresses the deadlock by ensuring that the secondary CPU
is not marked online before it's counters are synchronised.

This fix should also be backported to fix the race condition introduced
by the backport of commit 8f46cca1 ("MIPS: SMP: Fix possibility of
deadlock when bringing CPUs online"), through really that race only
existed before commit 8df3e07e ("cpu/hotplug: Let upcoming cpu
bring itself fully up").

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Fixes: 6f542ebe ("MIPS: Fix race on setting and getting cpu_online_mask")
CC: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>
Cc: <stable@vger.kernel.org> # v4.1+: 8f46cca1: "MIPS: SMP: Fix possibility of deadlock when bringing CPUs online"
Cc: <stable@vger.kernel.org> # v4.1+: a00eeede: "MIPS: SMP: Use a completion event to signal CPU up"
Cc: <stable@vger.kernel.org> # v4.1+: 6f542ebe: "MIPS: Fix race on setting and getting cpu_online_mask"
Cc: <stable@vger.kernel.org> # v4.1+
Patchwork: https://patchwork.linux-mips.org/patch/17376/

Signed-off-by: James Hogan <jhogan@kernel.org>

parent 6a2932a4

arch/mips/kernel/smp.c

+16 −6

Original line number	Diff line number	Diff line
		@@ -66,6 +66,7 @@ EXPORT_SYMBOL(cpu_sibling_map);
		cpumask_t cpu_core_map[NR_CPUS] __read_mostly;
		EXPORT_SYMBOL(cpu_core_map);

		static DECLARE_COMPLETION(cpu_starting);
		static DECLARE_COMPLETION(cpu_running);

		/*
		@@ -374,6 +375,12 @@ asmlinkage void start_secondary(void)
		cpumask_set_cpu(cpu, &cpu_coherent_mask);
		notify_cpu_starting(cpu);

		/* Notify boot CPU that we're starting & ready to sync counters */
		complete(&cpu_starting);

		synchronise_count_slave(cpu);

		/* The CPU is running and counters synchronised, now mark it online */
		set_cpu_online(cpu, true);

		set_cpu_sibling_map(cpu);
		@@ -381,8 +388,11 @@ asmlinkage void start_secondary(void)

		calculate_cpu_foreign_map();

		/*
		* Notify boot CPU that we're up & online and it can safely return
		* from __cpu_up
		*/
		complete(&cpu_running);
		synchronise_count_slave(cpu);

		/*
		* irq will be enabled in ->smp_finish(), enabling it too early
		@@ -445,17 +455,17 @@ int __cpu_up(unsigned int cpu, struct task_struct *tidle)
		if (err)
		return err;

		/*
		* We must check for timeout here, as the CPU will not be marked
		* online until the counters are synchronised.
		*/
		if (!wait_for_completion_timeout(&cpu_running,
		/* Wait for CPU to start and be ready to sync counters */
		if (!wait_for_completion_timeout(&cpu_starting,
		msecs_to_jiffies(1000))) {
		pr_crit("CPU%u: failed to start\n", cpu);
		return -EIO;
		}

		synchronise_count_master(cpu);

		/* Wait for CPU to finish startup & mark itself online before return */
		wait_for_completion(&cpu_running);
		return 0;
		}

Admin message