perf tools: Add support for disabling -Werror via WERROR=0 (9e59e099) · Commits · 戴 / test

GCC often introduces new warnings with lots of false positives - breaking -Werror builds. WERROR=0 allows one to build perf without much fuss - while still encouraging people to send patches to avoid the fuss of having to type WERROR=0. Bisecting back to commits that produce a (mostly harmless) warning on some compilers is more difficult. With WERROR=0 one could bisect without worrying about harmless warnings. Cc: Ingo Molnar <mingo@elte.hu> Link: http://lkml.kernel.org/r/eac06c7cc4920e5d4830417d466161fb26c7359c.1315514559.git.dvhart@linux.intel.com Signed-off-by:

Darren Hart <dvhart@linux.intel.com> Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/Makefile

+8 −1

Original line number	Diff line number	Diff line
		@@ -30,6 +30,8 @@ endif
		# Define EXTRA_CFLAGS=-m64 or EXTRA_CFLAGS=-m32 as appropriate for cross-builds.
		#
		# Define NO_DWARF if you do not want debug-info analysis feature at all.
		#
		# Define WERROR=0 to disable treating any warnings as errors.

		$(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE
		@$(SHELL_PATH) util/PERF-VERSION-GEN $(OUTPUT)
		@@ -63,6 +65,11 @@ ifeq ($(ARCH),x86_64)
		endif
		endif

		# Treat warnings as errors unless directed not to
		ifneq ($(WERROR),0)
		CFLAGS_WERROR := -Werror
		endif

		#
		# Include saner warnings here, which can catch bugs:
		#
		@@ -95,7 +102,7 @@ ifndef PERF_DEBUG
		CFLAGS_OPTIMIZE = -O6
		endif

		CFLAGS = -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99 -Werror $(CFLAGS_OPTIMIZE) -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
		CFLAGS = -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99 $(CFLAGS_WERROR) $(CFLAGS_OPTIMIZE) -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
		EXTLIBS = -lpthread -lrt -lelf -lm
		ALL_CFLAGS = $(CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
		ALL_LDFLAGS = $(LDFLAGS)

Admin message