Commit 9e41dd35 authored Apr 12, 2012 by Andrei Warkentin Committed by NeilBrown Apr 12, 2012

MD: Bitmap version cleanup.



bitmap_new_disk_sb() would still create V3 bitmap superblock
with host-endian layout.

Perhaps I'm confused, but shouldn't bitmap_new_disk_sb() be
creating a V4 bitmap superblock instead, that is portable,
as per comment in bitmap.h?

Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>

parent 5020ad7d

drivers/md/bitmap.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -539,9 +539,6 @@ static int bitmap_new_disk_sb(struct bitmap *bitmap)
		bitmap->events_cleared = bitmap->mddev->events;
		sb->events_cleared = cpu_to_le64(bitmap->mddev->events);

		bitmap->flags \|= BITMAP_HOSTENDIAN;
		sb->version = cpu_to_le32(BITMAP_MAJOR_HOSTENDIAN);

		kunmap_atomic(sb);

		return 0;

Admin message