Commit 9e3e365a authored by Dick Kennedy's avatar Dick Kennedy Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix no message shown for lpfc_hdw_queue out of range value 

If module parameters override the default configuration settings for
hardware queues or irqs, the driver was not notifying the change from
defaults.

Revise such that any changes will result in a kernel log message.

Link: https://lore.kernel.org/r/20200803210229.23063-3-jsmart2021@gmail.com


Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a1e4d3d8

drivers/scsi/lpfc/lpfc_attr.c

+17 −3
Original line number Diff line number Diff line
@@ -7412,12 +7412,26 @@ lpfc_get_cfgparam(struct lpfc_hba *phba) 
void

lpfc_nvme_mod_param_dep(struct lpfc_hba *phba)

{

	if (phba->cfg_hdw_queue > phba->sli4_hba.num_present_cpu)

	int  logit = 0;



	if (phba->cfg_hdw_queue > phba->sli4_hba.num_present_cpu) {

		phba->cfg_hdw_queue = phba->sli4_hba.num_present_cpu;

	if (phba->cfg_irq_chann > phba->sli4_hba.num_present_cpu)

		logit = 1;

	}

	if (phba->cfg_irq_chann > phba->sli4_hba.num_present_cpu) {

		phba->cfg_irq_chann = phba->sli4_hba.num_present_cpu;

	if (phba->cfg_irq_chann > phba->cfg_hdw_queue)

		logit = 1;

	}

	if (phba->cfg_irq_chann > phba->cfg_hdw_queue) {

		phba->cfg_irq_chann = phba->cfg_hdw_queue;

		logit = 1;

	}

	if (logit)

		lpfc_printf_log(phba, KERN_ERR, LOG_SLI,

				"2006 Reducing Queues - CPU limitation: "

				"IRQ %d HDWQ %d\n",

				phba->cfg_irq_chann,

				phba->cfg_hdw_queue);



	if (phba->cfg_enable_fc4_type & LPFC_ENABLE_NVME &&

	    phba->nvmet_support) {

drivers/scsi/lpfc/lpfc_init.c

+2 −1
Original line number Diff line number Diff line
@@ -8637,7 +8637,8 @@ lpfc_sli4_read_config(struct lpfc_hba *phba) 
		if ((phba->cfg_irq_chann > qmin) ||

		    (phba->cfg_hdw_queue > qmin)) {

			lpfc_printf_log(phba, KERN_ERR, LOG_TRACE_EVENT,

					"2005 Reducing Queues: "

					"2005 Reducing Queues - "

					"FW resource limitation: "

					"WQ %d CQ %d EQ %d: min %d: "

					"IRQ %d HDWQ %d\n",

					phba->sli4_hba.max_cfg_param.max_wq,

CRA Git | Maintained and supported by SUSTech CRA and CCSE