gpio: use sizeof() instead of hardcoded values (9e089246) · Commits · 戴 / test

gpiolib uses a fixed string for the suffixes and defines it at 32 bytes. Later in the code snprintf is used with this fixed value of 32. Using sizeof() is safer in case the size for the suffixes is ever changed. Signed-off-by:

Olliver Schinagl <oliver@schinagl.nl> Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpiolib.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1665,9 +1665,11 @@ static struct gpio_desc of_find_gpio(struct device dev, const char *con_id,

		for (i = 0; i < ARRAY_SIZE(suffixes); i++) {
		if (con_id)
		snprintf(prop_name, 32, "%s-%s", con_id, suffixes[i]);
		snprintf(prop_name, sizeof(prop_name), "%s-%s", con_id,
		suffixes[i]);
		else
		snprintf(prop_name, 32, "%s", suffixes[i]);
		snprintf(prop_name, sizeof(prop_name), "%s",
		suffixes[i]);

		desc = of_get_named_gpiod_flags(dev->of_node, prop_name, idx,
		&of_flags);

Admin message