Commit 9def5dc1 authored Nov 18, 2019 by Wei Yongjun Committed by Greg Kroah-Hartman Nov 19, 2019

coresight: funnel: Fix missing spin_lock_init()



The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Tested-by: Yabin Cui <yabinc@google.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20191118185207.30441-2-mathieu.poirier@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7a7ebfa8

drivers/hwtracing/coresight/coresight-funnel.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -253,6 +253,7 @@ static int funnel_probe(struct device dev, struct resource res)
		}
		dev->platform_data = pdata;

		spin_lock_init(&drvdata->spinlock);
		desc.type = CORESIGHT_DEV_TYPE_LINK;
		desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_MERG;
		desc.ops = &funnel_cs_ops;

Admin message