Commit 9de4a4cc authored Nov 02, 2020 by Alex Elder Committed by Jakub Kicinski Nov 04, 2020

net: ipa: use version in gsi_channel_reset()



A quirk of IPA v3.5.1 requires a channel reset on an RX channel to
be performed twice.  Use the IPA version in gsi_channel_reset()
rather than the passed-in legacy flag to determine that.

This is actually a bug fix, because this double reset is supposed
to occur independent of whether we're enabling the doorbell engine.
Now they will be independent.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 56dfe8de

drivers/net/ipa/gsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -840,7 +840,7 @@ void gsi_channel_reset(struct gsi *gsi, u32 channel_id, bool legacy)

		gsi_channel_reset_command(channel);
		/* Due to a hardware quirk we may need to reset RX channels twice. */
		if (legacy && !channel->toward_ipa)
		if (gsi->version == IPA_VERSION_3_5_1 && !channel->toward_ipa)
		gsi_channel_reset_command(channel);

		gsi_channel_program(channel, legacy);

Admin message