Commit 9de1b51f authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: remove drm_bus->get_name 



The only user is the info debugfs file, so we only need something
human readable. Now for both pci and platform devices we've used the
name of the underlying device driver, which matches the name of the
drm driver in all cases. So we can just use that instead.

The exception is usb, which used a generic "USB". Not to harmful with
just one usb driver, but better to use "udl", too.

With that converted we can rip out all the ->get_name implementations.

Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 5829d183

drivers/gpu/drm/drm_info.c

+2 −4
Original line number Diff line number Diff line
@@ -47,18 +47,16 @@ int drm_name_info(struct seq_file *m, void *data) 
	struct drm_minor *minor = node->minor;

	struct drm_device *dev = minor->dev;

	struct drm_master *master = minor->master;

	const char *bus_name;

	if (!master)

		return 0;



	bus_name = dev->driver->bus->get_name(dev);

	if (master->unique) {

		seq_printf(m, "%s %s %s\n",

			   bus_name,

			   dev->driver->name,

			   dev_name(dev->dev), master->unique);

	} else {

		seq_printf(m, "%s %s\n",

			   bus_name, dev_name(dev->dev));

			   dev->driver->name, dev_name(dev->dev));

	}

	return 0;

}

drivers/gpu/drm/drm_pci.c

+0 −7
Original line number Diff line number Diff line
@@ -137,12 +137,6 @@ static int drm_get_pci_domain(struct drm_device *dev) 
	return pci_domain_nr(dev->pdev->bus);

}



static const char *drm_pci_get_name(struct drm_device *dev)

{

	struct pci_driver *pdriver = dev->driver->kdriver.pci;

	return pdriver->name;

}



static int drm_pci_set_busid(struct drm_device *dev, struct drm_master *master)

{

	int len, ret;
@@ -287,7 +281,6 @@ void drm_pci_agp_destroy(struct drm_device *dev) 
}



static struct drm_bus drm_pci_bus = {

	.get_name = drm_pci_get_name,

	.set_busid = drm_pci_set_busid,

};

drivers/gpu/drm/drm_platform.c

+0 −6
Original line number Diff line number Diff line
@@ -68,11 +68,6 @@ err_free: 
	return ret;

}



static const char *drm_platform_get_name(struct drm_device *dev)

{

	return dev->platformdev->name;

}



static int drm_platform_set_busid(struct drm_device *dev, struct drm_master *master)

{

	int len, ret, id;
@@ -107,7 +102,6 @@ err: 
}



static struct drm_bus drm_platform_bus = {

	.get_name = drm_platform_get_name,

	.set_busid = drm_platform_set_busid,

};

drivers/gpu/drm/drm_usb.c

+0 −6
Original line number Diff line number Diff line
@@ -36,11 +36,6 @@ err_free: 
}

EXPORT_SYMBOL(drm_get_usb_dev);



static const char *drm_usb_get_name(struct drm_device *dev)

{

	return "USB";

}



static int drm_usb_set_busid(struct drm_device *dev,

			       struct drm_master *master)

{
@@ -48,7 +43,6 @@ static int drm_usb_set_busid(struct drm_device *dev, 
}



static struct drm_bus drm_usb_bus = {

	.get_name = drm_usb_get_name,

	.set_busid = drm_usb_set_busid,

};

include/drm/drmP.h

+0 −1
Original line number Diff line number Diff line
@@ -726,7 +726,6 @@ struct drm_master { 
#define DRM_SCANOUTPOS_ACCURATE     (1 << 2)



struct drm_bus {

	const char *(*get_name)(struct drm_device *dev);

	int (*set_busid)(struct drm_device *dev, struct drm_master *master);

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE