Commit 9dd631fa authored Jan 08, 2020 by Malcolm Priestley Committed by Greg Kroah-Hartman Jan 10, 2020

staging: vt6656: Fix false Tx excessive retries reporting.



The driver reporting  IEEE80211_TX_STAT_ACK is not being handled
correctly. The driver should only report on TSR_TMO flag is not
set indicating no transmission errors and when not IEEE80211_TX_CTL_NO_ACK
is being requested.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Link: https://lore.kernel.org/r/340f1f7f-c310-dca5-476f-abc059b9cd97@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d579c43c

drivers/staging/vt6656/int.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -99,8 +99,10 @@ static int vnt_int_report_rate(struct vnt_private *priv, u8 pkt_no, u8 tsr)

		info->status.rates[0].count = tx_retry;

		if (!(tsr & (TSR_TMO \| TSR_RETRYTMO))) {
		if (!(tsr & TSR_TMO)) {
		info->status.rates[0].idx = idx;

		if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
		info->flags \|= IEEE80211_TX_STAT_ACK;
		}

Admin message