Commit 9d8c05ad authored Oct 02, 2020 by Paolo Abeni Committed by David S. Miller Oct 02, 2020

tcp: fix syn cookied MPTCP request socket leak

If a syn-cookies request socket don't pass MPTCP-level
validation done in syn_recv_sock(), we need to release
it immediately, or it will be leaked.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/89


Fixes: 9466a1cc ("mptcp: enable JOIN requests even if cookies are in use")
Reported-and-tested-by: Geliang Tang <geliangtang@gmail.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e7d4005d

net/ipv4/syncookies.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -214,7 +214,7 @@ struct sock tcp_get_cookie_sock(struct sock sk, struct sk_buff *skb,
		sock_rps_save_rxhash(child, skb);

		if (rsk_drop_req(req)) {
		refcount_set(&req->rsk_refcnt, 2);
		reqsk_put(req);
		return child;
		}

Admin message