Unverified Commit 9d6ee365 authored Feb 19, 2020 by Jerome Brunet Committed by Mark Brown Feb 20, 2020

ASoC: dpcm: remove confusing trace in dpcm_get_be()



Now that dpcm_get_be() is used in dpcm_end_walk_at_be(), it is not a error
if this function does not find a BE for the provided widget. Remove the
related dev_err() trace which is confusing since things might be working
as expected.

When called from dpcm_add_paths(), it is an error if dpcm_get_be() fails to
find a BE for the provided widget. The necessary error trace is already
done in this case.

Fixes: 027a4838 ("ASoC: soc-pcm: use dpcm_get_be() at dpcm_end_walk_at_be()")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20200219115048.934678-1-jbrunet@baylibre.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 95e9e205

sound/soc/soc-pcm.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1270,9 +1270,7 @@ static struct snd_soc_pcm_runtime dpcm_get_be(struct snd_soc_card card,
		}
		}

		/* dai link name and stream name set correctly ? */
		dev_err(card->dev, "ASoC: can't get %s BE for %s\n",
		stream ? "capture" : "playback", widget->name);
		/* Widget provided is not a BE */
		return NULL;
		}

Admin message