Commit 9d5f82c8 authored Apr 20, 2020 by Mathieu Poirier Committed by Bjorn Andersson Apr 20, 2020

remoteproc: Restructure firmware name allocation



Improve the readability of function rproc_alloc_firmware() by using
a non-negated condition and moving the comment out of the conditional
block

Suggested-by: Alex Elder <elder@linaro.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20200420231601.16781-3-mathieu.poirier@linaro.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 1487deda

drivers/remoteproc/remoteproc_core.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -2011,14 +2011,14 @@ static int rproc_alloc_firmware(struct rproc *rproc,
		{
		const char *p;

		if (!firmware)
		/*
		* If the caller didn't pass in a firmware name then
		* construct a default name.
		* Allocate a firmware name if the caller gave us one to work
		* with. Otherwise construct a new one using a default pattern.
		*/
		p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name);
		else
		if (firmware)
		p = kstrdup_const(firmware, GFP_KERNEL);
		else
		p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name);

		if (!p)
		return -ENOMEM;

Admin message