Commit 9d2ab995 authored by Kunihiko Hayashi's avatar Kunihiko Hayashi Committed by Tejun Heo
Browse files

ata: libahci_platform: add reset control support 

Add support to get and control a list of resets for the device
as optional and shared. These resets must be kept de-asserted until
the device is enabled.

This is specified as shared because some SoCs like UniPhier series
have common reset controls with all ahci controller instances.

However, according to Thierry's view,
https://www.spinics.net/lists/linux-ide/msg55357.html


some hardware-specific drivers already use their own resets,
and the common reset make a path to occur double controls of resets.

The ahci_platform_get_resources() can get and control the reset
only when the second argument includes AHCI_PLATFORM_GET_RESETS bit.

Suggested-by: default avatarHans de Goede <hdegoede@redhat.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 16af2d65

Documentation/devicetree/bindings/ata/ahci-platform.txt

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ compatible: 
Optional properties:

- dma-coherent      : Present if dma operations are coherent

- clocks            : a list of phandle + clock specifier pairs

- resets            : a list of phandle + reset specifier pairs

- target-supply     : regulator for SATA target power

- phys              : reference to the SATA PHY node

- phy-names         : must be "sata-phy"

drivers/ata/ahci.h

+1 −0
Original line number Diff line number Diff line
@@ -350,6 +350,7 @@ struct ahci_host_priv { 
	u32			em_msg_type;	/* EM message type */

	bool			got_runtime_pm; /* Did we do pm_runtime_get? */

	struct clk		*clks[AHCI_MAX_CLKS]; /* Optional */

	struct reset_control	*rsts;		/* Optional */

	struct regulator	**target_pwrs;	/* Optional */

	/*

	 * If platform uses PHYs. There is a 1:1 relation between the port number and

drivers/ata/libahci_platform.c

+26 −5
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <linux/phy/phy.h>

#include <linux/pm_runtime.h>

#include <linux/of_platform.h>

#include <linux/reset.h>

#include "ahci.h"



static void ahci_host_stop(struct ata_host *host);
@@ -195,7 +196,8 @@ EXPORT_SYMBOL_GPL(ahci_platform_disable_regulators); 
 * following order:

 * 1) Regulator

 * 2) Clocks (through ahci_platform_enable_clks)

 * 3) Phys

 * 3) Resets

 * 4) Phys

 *

 * If resource enabling fails at any point the previous enabled resources

 * are disabled in reverse order.
@@ -215,12 +217,19 @@ int ahci_platform_enable_resources(struct ahci_host_priv *hpriv) 
	if (rc)

		goto disable_regulator;



	rc = ahci_platform_enable_phys(hpriv);

	rc = reset_control_deassert(hpriv->rsts);

	if (rc)

		goto disable_clks;



	rc = ahci_platform_enable_phys(hpriv);

	if (rc)

		goto disable_resets;



	return 0;



disable_resets:

	reset_control_assert(hpriv->rsts);



disable_clks:

	ahci_platform_disable_clks(hpriv);
@@ -238,13 +247,16 @@ EXPORT_SYMBOL_GPL(ahci_platform_enable_resources); 
 * This function disables all ahci_platform managed resources in the

 * following order:

 * 1) Phys

 * 2) Clocks (through ahci_platform_disable_clks)

 * 3) Regulator

 * 2) Resets

 * 3) Clocks (through ahci_platform_disable_clks)

 * 4) Regulator

 */

void ahci_platform_disable_resources(struct ahci_host_priv *hpriv)

{

	ahci_platform_disable_phys(hpriv);



	reset_control_assert(hpriv->rsts);



	ahci_platform_disable_clks(hpriv);



	ahci_platform_disable_regulators(hpriv);
@@ -341,7 +353,8 @@ static int ahci_platform_get_regulator(struct ahci_host_priv *hpriv, u32 port, 
 * 2) regulator for controlling the targets power (optional)

 * 3) 0 - AHCI_MAX_CLKS clocks, as specified in the devs devicetree node,

 *    or for non devicetree enabled platforms a single clock

 * 4) phys (optional)

 * 4) resets, if flags has AHCI_PLATFORM_GET_RESETS (optional)

 * 5) phys (optional)

 *

 * RETURNS:

 * The allocated ahci_host_priv on success, otherwise an ERR_PTR value
@@ -395,6 +408,14 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, 
		hpriv->clks[i] = clk;

	}



	if (flags & AHCI_PLATFORM_GET_RESETS) {

		hpriv->rsts = devm_reset_control_array_get_optional_shared(dev);

		if (IS_ERR(hpriv->rsts)) {

			rc = PTR_ERR(hpriv->rsts);

			goto err_out;

		}

	}



	hpriv->nports = child_nodes = of_get_child_count(dev->of_node);



	/*

include/linux/ahci_platform.h

+2 −0
Original line number Diff line number Diff line
@@ -43,4 +43,6 @@ int ahci_platform_resume_host(struct device *dev); 
int ahci_platform_suspend(struct device *dev);

int ahci_platform_resume(struct device *dev);



#define AHCI_PLATFORM_GET_RESETS	0x01



#endif /* _AHCI_PLATFORM_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE