Commit 9d1f8a40 authored Jan 22, 2011 by Henrik Rydberg Committed by Guenter Roeck Jan 23, 2011

hwmon: (applesmc) Properly initialize lockdep attributes



The switch to dynamically allocated sysfs attributes left the
internal lockdep members uninitialized, causing a formal bug.
This patch adds sysfs_attr_init() to the node creation function,
remedying the problem.

Reported-and-tested-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

parent 1bae4ce2

drivers/hwmon/applesmc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1072,6 +1072,7 @@ static int applesmc_create_nodes(struct applesmc_node_group *groups, int num)
		node->sda.dev_attr.show = grp->show;
		node->sda.dev_attr.store = grp->store;
		attr = &node->sda.dev_attr.attr;
		sysfs_attr_init(attr);
		attr->name = node->name;
		attr->mode = S_IRUGO \| (grp->store ? S_IWUSR : 0);
		ret = sysfs_create_file(&pdev->dev.kobj, attr);

Admin message