Commit 9d149045 authored Jun 03, 2020 by Jiri Benc Committed by David S. Miller Jun 04, 2020

geneve: change from tx_error to tx_dropped on missing metadata



If the geneve interface is in collect_md (external) mode, it can't send any
packets submitted directly to its net interface, as such packets won't have
metadata attached. This is expected.

However, the kernel itself sends some packets to the interface, most
notably, IPv6 DAD, IPv6 multicast listener reports, etc. This is not wrong,
as tunnel metadata can be specified in routing table (although technically,
that has never worked for IPv6, but hopefully will be fixed eventually) and
then the interface must correctly participate in IPv6 housekeeping.

The problem is that any such attempt increases the tx_error counter. Just
bringing up a geneve interface with IPv6 enabled is enough to see a number
of tx_errors. That causes confusion among users, prompting them to find
a network error where there is none.

Change the counter used to tx_dropped. That better conveys the meaning
(there's nothing wrong going on, just some packets are getting dropped) and
hopefully will make admins panic less.

Signed-off-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a9a7d129

drivers/net/geneve.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -987,9 +987,10 @@ static netdev_tx_t geneve_xmit(struct sk_buff skb, struct net_device dev)
		if (geneve->collect_md) {
		info = skb_tunnel_info(skb);
		if (unlikely(!info \|\| !(info->mode & IP_TUNNEL_INFO_TX))) {
		err = -EINVAL;
		netdev_dbg(dev, "no tunnel metadata\n");
		goto tx_error;
		dev_kfree_skb(skb);
		dev->stats.tx_dropped++;
		return NETDEV_TX_OK;
		}
		} else {
		info = &geneve->info;
		@@ -1006,7 +1007,7 @@ static netdev_tx_t geneve_xmit(struct sk_buff skb, struct net_device dev)

		if (likely(!err))
		return NETDEV_TX_OK;
		tx_error:

		dev_kfree_skb(skb);

		if (err == -ELOOP)

Admin message