Commit 9d09dd8d authored by James Smart's avatar James Smart Committed by Christoph Hellwig
Browse files

nvmet: add transport discovery change op 



Some transports, such as FC-NVME, support discovery controller change
events without the use of a persistent discovery controller. FC receives
events via RSCN from the FC Fabric Controller or subsystem FC port.

This patch adds a nvmet transport op that is called whenever a
discovery change event occurs in the nvmet layer.

To facilitate the callback without adding another layer to cross into
core.c to reference the transport ops, the port structure snapshots
the transport ops when the port is enabled and clears them when disabled.

Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarArun Easi <aeasi@marvell.com>
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 474a2800

drivers/nvme/target/core.c

+2 −0
Original line number Diff line number Diff line
@@ -311,6 +311,7 @@ int nvmet_enable_port(struct nvmet_port *port) 
		port->inline_data_size = 0;



	port->enabled = true;

	port->tr_ops = ops;

	return 0;

}
@@ -321,6 +322,7 @@ void nvmet_disable_port(struct nvmet_port *port) 
	lockdep_assert_held(&nvmet_config_sem);



	port->enabled = false;

	port->tr_ops = NULL;



	ops = nvmet_transports[port->disc_addr.trtype];

	ops->remove_port(port);

drivers/nvme/target/discovery.c

+4 −0
Original line number Diff line number Diff line
@@ -41,6 +41,10 @@ void nvmet_port_disc_changed(struct nvmet_port *port, 
		__nvmet_disc_changed(port, ctrl);

	}

	mutex_unlock(&nvmet_disc_subsys->lock);



	/* If transport can signal change, notify transport */

	if (port->tr_ops && port->tr_ops->discovery_chg)

		port->tr_ops->discovery_chg(port);

}



static void __nvmet_subsys_disc_changed(struct nvmet_port *port,

drivers/nvme/target/nvmet.h

+2 −0
Original line number Diff line number Diff line
@@ -140,6 +140,7 @@ struct nvmet_port { 
	void				*priv;

	bool				enabled;

	int				inline_data_size;

	const struct nvmet_fabrics_ops	*tr_ops;

};



static inline struct nvmet_port *to_nvmet_port(struct config_item *item)
@@ -277,6 +278,7 @@ struct nvmet_fabrics_ops { 
	void (*disc_traddr)(struct nvmet_req *req,

			struct nvmet_port *port, char *traddr);

	u16 (*install_queue)(struct nvmet_sq *nvme_sq);

	void (*discovery_chg)(struct nvmet_port *port);

};



#define NVMET_MAX_INLINE_BIOVEC	8

CRA Git | Maintained and supported by SUSTech CRA and CCSE