Commit 9cf71edb authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: au1xxx: remove goto label 

Simplify the driver by removing the goto label as it only does return ret.

Link: https://lore.kernel.org/r/20200306005958.39203-2-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 7fc9790a

drivers/rtc/rtc-au1xxx.c

+2 −9
Original line number Diff line number Diff line
@@ -65,17 +65,13 @@ static int au1xtoy_rtc_probe(struct platform_device *pdev) 
{

	struct rtc_device *rtcdev;

	unsigned long t;

	int ret;



	t = alchemy_rdsys(AU1000_SYS_CNTRCTRL);

	if (!(t & CNTR_OK)) {

		dev_err(&pdev->dev, "counters not working; aborting.\n");

		ret = -ENODEV;

		goto out_err;

		return -ENODEV;

	}



	ret = -ETIMEDOUT;



	/* set counter0 tickrate to 1Hz if necessary */

	if (alchemy_rdsys(AU1000_SYS_TOYTRIM) != 32767) {

		/* wait until hardware gives access to TRIM register */
@@ -88,7 +84,7 @@ static int au1xtoy_rtc_probe(struct platform_device *pdev) 
			 * counters are unusable.

			 */

			dev_err(&pdev->dev, "timeout waiting for access\n");

			goto out_err;

			return -ETIMEDOUT;

		}



		/* set 1Hz TOY tick rate */
@@ -108,9 +104,6 @@ static int au1xtoy_rtc_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, rtcdev);



	return rtc_register_device(rtcdev);



out_err:

	return ret;

}



static struct platform_driver au1xrtc_driver = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE