Commit 9ced4548 authored Jan 20, 2020 by Jules Irenge Committed by Paul E. McKenney Feb 20, 2020

rcu: Add missing annotation for rcu_nocb_bypass_lock()



Sparse reports warning at rcu_nocb_bypass_lock()

|warning: context imbalance in rcu_nocb_bypass_lock() - wrong count at exit

To fix this, this commit adds an __acquires(&rdp->nocb_bypass_lock).
Given that rcu_nocb_bypass_lock() does actually call raw_spin_lock()
when raw_spin_trylock() fails, this not only fixes the warning but also
improves on the readability of the code.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent 5648d659

kernel/rcu/tree_plugin.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -1486,6 +1486,7 @@ module_param(nocb_nobypass_lim_per_jiffy, int, 0);
		* flag the contention.
		*/
		static void rcu_nocb_bypass_lock(struct rcu_data *rdp)
		__acquires(&rdp->nocb_bypass_lock)
		{
		lockdep_assert_irqs_disabled();
		if (raw_spin_trylock(&rdp->nocb_bypass_lock))

Admin message