Commit 9ce5fe95 authored Aug 31, 2020 by Cengiz Can Committed by Mauro Carvalho Chehab Sep 22, 2020

media: staging: atomisp: Remove unnecessary 'fallthrough'



commit df561f66 ("treewide: Use fallthrough pseudo-keyword") from
Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments
with 'fallthrough' pseudo-keyword.

However, in one of the switch-case statements, Coverity Static Analyzer
throws a warning that 'fallthrough' is unreachable due to the adjacent
'return false' statement. (Coverity ID CID 1466511)

In order to fix the unreachable code warning, remove unnecessary
fallthrough keyword.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 2394984f

drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -700,7 +700,6 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd,
		return true;

		return false;
		fallthrough;
		case ATOMISP_RUN_MODE_VIDEO:
		if (!asd->continuous_mode->val) {
		if (pipe_id == IA_CSS_PIPE_ID_VIDEO \|\|

Admin message