Commit 9cddad77 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Greg Kroah-Hartman
Browse files

PM: Remove pm_parent from struct dev_pm_info 



The pm_parent member of struct dev_pm_info (defined in include/linux/pm.h) is
only used to check if the device's parent is in the right state while the
device is being suspended or resumed.  However, this can be done just as well
with the help of the parent pointer in struct device, so pm_parent can be
removed along with some code that handles it.

Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Acked-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 11048dcf

drivers/base/power/main.c

+4 −26
Original line number Diff line number Diff line
@@ -33,27 +33,6 @@ DEFINE_MUTEX(dpm_list_mtx); 


int (*platform_enable_wakeup)(struct device *dev, int is_on);





/**

 *	device_pm_set_parent - Specify power dependency.

 *	@dev:		Device who needs power.

 *	@parent:	Device that supplies power.

 *

 *	This function is used to manually describe a power-dependency

 *	relationship. It may be used to specify a transversal relationship

 *	(where the power supplier is not the physical (or electrical)

 *	ancestor of a specific device.

 *	The effect of this is that the supplier will not be powered down

 *	before the power dependent.

 */



void device_pm_set_parent(struct device * dev, struct device * parent)

{

	put_device(dev->power.pm_parent);

	dev->power.pm_parent = get_device(parent);

}

EXPORT_SYMBOL_GPL(device_pm_set_parent);



int device_pm_add(struct device *dev)

{

	int error;
@@ -63,8 +42,8 @@ int device_pm_add(struct device * dev) 
		 kobject_name(&dev->kobj));

	mutex_lock(&dpm_list_mtx);

	list_add_tail(&dev->power.entry, &dpm_active);

	device_pm_set_parent(dev, dev->parent);

	if ((error = dpm_sysfs_add(dev)))

	error = dpm_sysfs_add(dev);

	if (error)

		list_del(&dev->power.entry);

	mutex_unlock(&dpm_list_mtx);

	return error;
@@ -77,7 +56,6 @@ void device_pm_remove(struct device * dev) 
		 kobject_name(&dev->kobj));

	mutex_lock(&dpm_list_mtx);

	dpm_sysfs_remove(dev);

	put_device(dev->power.pm_parent);

	list_del_init(&dev->power.entry);

	mutex_unlock(&dpm_list_mtx);

}

drivers/base/power/resume.c

+3 −4
Original line number Diff line number Diff line
@@ -29,12 +29,11 @@ int resume_device(struct device * dev) 


	down(&dev->sem);



	if (dev->power.pm_parent

			&& dev->power.pm_parent->power.power_state.event) {

	if (dev->parent && dev->parent->power.power_state.event) {

		dev_err(dev, "PM: resume from %d, parent %s still %d\n",

			dev->power.power_state.event,

			dev->power.pm_parent->bus_id,

			dev->power.pm_parent->power.power_state.event);

			dev->parent->bus_id,

			dev->parent->power.power_state.event);

	}



	if (dev->bus && dev->bus->resume) {

drivers/base/power/suspend.c

+3 −4
Original line number Diff line number Diff line
@@ -55,13 +55,12 @@ int suspend_device(struct device * dev, pm_message_t state) 
		dev_dbg(dev, "PM: suspend %d-->%d\n",

			dev->power.power_state.event, state.event);

	}

	if (dev->power.pm_parent

			&& dev->power.pm_parent->power.power_state.event) {

	if (dev->parent && dev->parent->power.power_state.event) {

		dev_err(dev,

			"PM: suspend %d->%d, parent %s already %d\n",

			dev->power.power_state.event, state.event,

			dev->power.pm_parent->bus_id,

			dev->power.pm_parent->power.power_state.event);

			dev->parent->bus_id,

			dev->parent->power.power_state.event);

	}



	dev->power.prev_state = dev->power.power_state;

include/linux/pm.h

+0 −3
Original line number Diff line number Diff line
@@ -269,13 +269,10 @@ struct dev_pm_info { 
	unsigned		should_wakeup:1;

	pm_message_t		prev_state;

	void			* saved_state;

	struct device		* pm_parent;

	struct list_head	entry;

#endif

};



extern void device_pm_set_parent(struct device * dev, struct device * parent);



extern int device_power_down(pm_message_t state);

extern void device_power_up(void);

extern void device_resume(void);

CRA Git | Maintained and supported by SUSTech CRA and CCSE