Commit 9ccaf106 authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Bartosz Golaszewski
Browse files

gpio: tegra: Use NOIRQ phase for suspend/resume 



All GPIO interrupts are disabled during of the NOIRQ suspend/resume
phase, thus there is no need to manually disable the interrupts. This
patch doesn't fix any problem, this is just a minor clean-up.

Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
Tested-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent f56d979c

drivers/gpio/gpio-tegra.c

+2 −8
Original line number Diff line number Diff line
@@ -416,11 +416,8 @@ static void tegra_gpio_irq_handler(struct irq_desc *desc) 
static int tegra_gpio_resume(struct device *dev)

{

	struct tegra_gpio_info *tgi = dev_get_drvdata(dev);

	unsigned long flags;

	unsigned int b, p;



	local_irq_save(flags);



	for (b = 0; b < tgi->bank_count; b++) {

		struct tegra_gpio_bank *bank = &tgi->bank_info[b];
@@ -448,17 +445,14 @@ static int tegra_gpio_resume(struct device *dev) 
		}

	}



	local_irq_restore(flags);

	return 0;

}



static int tegra_gpio_suspend(struct device *dev)

{

	struct tegra_gpio_info *tgi = dev_get_drvdata(dev);

	unsigned long flags;

	unsigned int b, p;



	local_irq_save(flags);

	for (b = 0; b < tgi->bank_count; b++) {

		struct tegra_gpio_bank *bank = &tgi->bank_info[b];
@@ -488,7 +482,7 @@ static int tegra_gpio_suspend(struct device *dev) 
					  GPIO_INT_ENB(tgi, gpio));

		}

	}

	local_irq_restore(flags);



	return 0;

}
@@ -562,7 +556,7 @@ static inline void tegra_gpio_debuginit(struct tegra_gpio_info *tgi) 
#endif



static const struct dev_pm_ops tegra_gpio_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(tegra_gpio_suspend, tegra_gpio_resume)

	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(tegra_gpio_suspend, tegra_gpio_resume)

};



static int tegra_gpio_probe(struct platform_device *pdev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE