Commit 9cc02f4c authored May 19, 2020 by Miquel Raynal

mtd: rawnand: fsmc: Stop using nand_release()



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-18-miquel.raynal@bootlin.com

parent f6c4e661

drivers/mtd/nand/raw/fsmc_nand.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1136,7 +1136,12 @@ static int fsmc_nand_remove(struct platform_device *pdev)
		struct fsmc_nand_data *host = platform_get_drvdata(pdev);

		if (host) {
		nand_release(&host->nand);
		struct nand_chip *chip = &host->nand;
		int ret;

		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		fsmc_nand_disable(host);

		if (host->mode == USE_DMA_ACCESS) {

Admin message