Commit 9ca7ad6c authored Jun 26, 2019 by Jeffrey Hugo Committed by Sean Paul Aug 01, 2019

drm: msm: Fix add_gpu_components

add_gpu_components() adds found GPU nodes from the DT to the match list,
regardless of the status of the nodes. This is a problem, because if the
nodes are disabled, they should not be on the match list because they will
not be matched. This prevents display from initing if a GPU node is
defined, but it's status is disabled.

Fix this by checking the node's status before adding it to the match list.

Fixes: dc3ea265 (drm/msm: Drop the gpu binding)
Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190626180015.45242-1-jeffrey.l.hugo@gmail.com

parent c14b5dce

drivers/gpu/drm/msm/msm_drv.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1279,6 +1279,7 @@ static int add_gpu_components(struct device *dev,
		if (!np)
		return 0;

		if (of_device_is_available(np))
		drm_of_component_match_add(dev, matchptr, compare_of, np);

		of_node_put(np);