Commit 9c9d0acb authored Jul 19, 2020 by Jim Cromie Committed by Greg Kroah-Hartman Jul 24, 2020

dyndbg: prefer declarative init in caller, to memset in callee



ddebug_exec_query declares an auto var, and passes it to
ddebug_parse_query, which memsets it before using it.  Drop that
memset, instead initialize the variable in the caller; let the
compiler decide how to do it.

Acked-by:  <jbaron@akamai.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/r/20200719231058.1586423-10-jim.cromie@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0b8f96be

lib/dynamic_debug.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -330,7 +330,6 @@ static int ddebug_parse_query(char *words[], int nwords,
		pr_err("expecting pairs of match-spec <value>\n");
		return -EINVAL;
		}
		memset(query, 0, sizeof(*query));

		if (modname)
		/* support $modname.dyndbg=<multiple queries> */
		@@ -448,7 +447,7 @@ static int ddebug_parse_flags(const char str, unsigned int flagsp,
		static int ddebug_exec_query(char query_string, const char modname)
		{
		unsigned int flags = 0, mask = 0;
		struct ddebug_query query;
		struct ddebug_query query = {};
		#define MAXWORDS 9
		int nwords, nfound;
		char *words[MAXWORDS];

Admin message