Commit 9c8bb163 authored Feb 08, 2017 by Hangbin Liu Committed by David S. Miller Feb 09, 2017

igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()

In function igmpv3/mld_add_delrec() we allocate pmc and put it in
idev->mc_tomb, so we should free it when we don't need it in del_delrec().
But I removed kfree(pmc) incorrectly in latest two patches. Now fix it.

Fixes: 24803f38 ("igmp: do not remove igmp souce list info when ...")
Fixes: 1666d49e ("mld: do not remove mld souce list info when ...")
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e2e004ac

net/ipv4/igmp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1172,6 +1172,7 @@ static void igmpv3_del_delrec(struct in_device in_dev, struct ip_mc_list im)
		psf->sf_crcount = im->crcount;
		}
		in_dev_put(pmc->interface);
		kfree(pmc);
		}
		spin_unlock_bh(&im->lock);
		}

net/ipv6/mcast.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -779,6 +779,7 @@ static void mld_del_delrec(struct inet6_dev idev, struct ifmcaddr6 im)
		psf->sf_crcount = im->mca_crcount;
		}
		in6_dev_put(pmc->idev);
		kfree(pmc);
		}
		spin_unlock_bh(&im->mca_lock);
		}

Admin message