Commit 9c890a79 authored by Jitendra Bhivare's avatar Jitendra Bhivare Committed by Martin K. Petersen
Browse files

be2iscsi: Remove unused mcc_cq_lock 



mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is
called only when all interrupts are disabled from mgmt_epfw_cleanup
during unloading of driver. There is no other context where there can be
contention for the processing of CQ.

Signed-off-by: default avatarJitendra Bhivare <jitendra.bhivare@broadcom.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent aee5618d

drivers/scsi/be2iscsi/be.h

+0 −1
Original line number Diff line number Diff line
@@ -132,7 +132,6 @@ struct be_ctrl_info { 
	/* MCC Rings */

	struct be_mcc_obj mcc_obj;

	spinlock_t mcc_lock;	/* For serializing mcc cmds to BE card */

	spinlock_t mcc_cq_lock;



	wait_queue_head_t mcc_wait[MAX_MCC_CMD + 1];

	unsigned int mcc_tag[MAX_MCC_CMD];

drivers/scsi/be2iscsi/be_cmds.c

+0 −2
Original line number Diff line number Diff line
@@ -532,7 +532,6 @@ int beiscsi_process_mcc(struct beiscsi_hba *phba) 
	int num = 0, status = 0;

	struct be_ctrl_info *ctrl = &phba->ctrl;



	spin_lock_bh(&phba->ctrl.mcc_cq_lock);

	while ((compl = be_mcc_compl_get(phba))) {

		if (compl->flags & CQE_FLAGS_ASYNC_MASK) {

			beiscsi_process_async_event(phba, compl);
@@ -547,7 +546,6 @@ int beiscsi_process_mcc(struct beiscsi_hba *phba) 
	if (num)

		hwi_ring_cq_db(phba, phba->ctrl.mcc_obj.cq.id, num, 1);



	spin_unlock_bh(&phba->ctrl.mcc_cq_lock);

	return status;

}

drivers/scsi/be2iscsi/be_main.c

+0 −1
Original line number Diff line number Diff line
@@ -730,7 +730,6 @@ static int be_ctrl_init(struct beiscsi_hba *phba, struct pci_dev *pdev) 
	memset(mbox_mem_align->va, 0, sizeof(struct be_mcc_mailbox));

	mutex_init(&ctrl->mbox_lock);

	spin_lock_init(&phba->ctrl.mcc_lock);

	spin_lock_init(&phba->ctrl.mcc_cq_lock);



	return status;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE