Commit 9c874716 authored Jul 05, 2016 by Gabriel Krisman Bertazi Committed by Jens Axboe Jul 13, 2016

block: atari: Return early for unsupported sector size

For 4K LBA or very large disks, atari_partition can easily get tricked
into thinking it has found an Atari partition table.  Depending on the
data in the disk, it ends up creating partitions with awkward lengths.

We saw logs like this while playing with fio.

[5.625867] nvme2n1: AHDI p2
[5.625872] nvme2n1: p2 size 2910030523 extends beyond EOD, truncated

People has had issues with misinterpreted AHDI partition tables for a long
time, see this BSD thread from 1995, for example.

https://mail-index.netbsd.org/port-atari/1995/11/19/0001.html



Since the atari partition, according to the spec, doesn't even support
sector sizes with more than 512, a quick sanity check is reasonable to
just bail out early, before even attempting to read sector 0.

Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 141fd28c

block/partitions/atari.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -42,6 +42,13 @@ int atari_partition(struct parsed_partitions *state)
		int part_fmt = 0; /* 0:unknown, 1:AHDI, 2:ICD/Supra */
		#endif

		/*
		* ATARI partition scheme supports 512 lba only. If this is not
		* the case, bail early to avoid miscalculating hd_size.
		*/
		if (bdev_logical_block_size(state->bdev) != 512)
		return 0;

		rs = read_part_sector(state, 0, &sect);
		if (!rs)
		return -1;

Admin message