Bluetooth: hci_qca: Remove redundant initializations to zero (9c81f2b7) · Commits · 戴 / test

The qca_data structure is allocated with kzalloc() and hence zero-initialized. Remove a bunch of unnecessary explicit initializations of struct members to zero. Signed-off-by:

Matthias Kaehlcke <mka@chromium.org> Reviewed-by:

Balakrishna Godavarthi <bgodavar@codeaurora.org> Signed-off-by:

Marcel Holtmann <marcel@holtmann.org>

drivers/bluetooth/hci_qca.c

+0 −19

Original line number	Diff line number	Diff line
		@@ -502,26 +502,7 @@ static int qca_open(struct hci_uart *hu)
		qca->tx_ibs_state = HCI_IBS_TX_ASLEEP;
		qca->rx_ibs_state = HCI_IBS_RX_ASLEEP;

		/* clocks actually on, but we start votes off */
		qca->tx_vote = false;
		qca->rx_vote = false;
		qca->flags = 0;

		qca->ibs_sent_wacks = 0;
		qca->ibs_sent_slps = 0;
		qca->ibs_sent_wakes = 0;
		qca->ibs_recv_wacks = 0;
		qca->ibs_recv_slps = 0;
		qca->ibs_recv_wakes = 0;
		qca->vote_last_jif = jiffies;
		qca->vote_on_ms = 0;
		qca->vote_off_ms = 0;
		qca->votes_on = 0;
		qca->votes_off = 0;
		qca->tx_votes_on = 0;
		qca->tx_votes_off = 0;
		qca->rx_votes_on = 0;
		qca->rx_votes_off = 0;

		hu->priv = qca;

Admin message