Commit 9c801f61 authored by Uladzislau Rezki (Sony)'s avatar Uladzislau Rezki (Sony) Committed by Linus Torvalds
Browse files

mm/vmalloc.c: remove BUG() from the find_va_links() 



Get rid of BUG() macro, that should be used only when a critical situation
happens and a system is not able to function anymore.

Replace it with WARN() macro instead, dump some extra information about
start/end addresses of both VAs which overlap.  Such overlap data can help
to figure out what happened making further analysis easier.  For example
if both areas are identical it could mean a double free.

A recovery process consists of declining all further steps regarding
inserting of conflicting overlap range.  In that sense find_va_links() now
can return NULL, so its return value has to be checked by callers.

Side effect of such process is it can leak memory, but it is better than
just killing a machine for no good reason.  Apart of that a debugging
process can be done on alive system.

Signed-off-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: Hillf Danton <hdanton@sina.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20200711104531.12242-1-urezki@gmail.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1a69a623

mm/vmalloc.c

+32 −9
Original line number Diff line number Diff line
@@ -512,6 +512,10 @@ static struct vmap_area *__find_vmap_area(unsigned long addr) 
/*

 * This function returns back addresses of parent node

 * and its left or right link for further processing.

 *

 * Otherwise NULL is returned. In that case all further

 * steps regarding inserting of conflicting overlap range

 * have to be declined and actually considered as a bug.

 */

static __always_inline struct rb_node **

find_va_links(struct vmap_area *va,
@@ -550,8 +554,12 @@ find_va_links(struct vmap_area *va, 
		else if (va->va_end > tmp_va->va_start &&

				va->va_start >= tmp_va->va_end)

			link = &(*link)->rb_right;

		else

			BUG();

		else {

			WARN(1, "vmalloc bug: 0x%lx-0x%lx overlaps with 0x%lx-0x%lx\n",

				va->va_start, va->va_end, tmp_va->va_start, tmp_va->va_end);



			return NULL;

		}

	} while (*link);



	*parent = &tmp_va->rb_node;
@@ -697,6 +705,7 @@ insert_vmap_area(struct vmap_area *va, 
	struct rb_node *parent;



	link = find_va_links(va, root, NULL, &parent);

	if (link)

		link_va(va, root, parent, link, head);

}
@@ -713,15 +722,22 @@ insert_vmap_area_augment(struct vmap_area *va, 
	else

		link = find_va_links(va, root, NULL, &parent);



	if (link) {

		link_va(va, root, parent, link, head);

		augment_tree_propagate_from(va);

	}

}



/*

 * Merge de-allocated chunk of VA memory with previous

 * and next free blocks. If coalesce is not done a new

 * free area is inserted. If VA has been merged, it is

 * freed.

 *

 * Please note, it can return NULL in case of overlap

 * ranges, followed by WARN() report. Despite it is a

 * buggy behaviour, a system can be alive and keep

 * ongoing.

 */

static __always_inline struct vmap_area *

merge_or_add_vmap_area(struct vmap_area *va,
@@ -738,6 +754,8 @@ merge_or_add_vmap_area(struct vmap_area *va, 
	 * inserted, unless it is merged with its sibling/siblings.

	 */

	link = find_va_links(va, root, NULL, &parent);

	if (!link)

		return NULL;



	/*

	 * Get next node of VA to check if merging can be done.
@@ -1346,6 +1364,9 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end) 
		va = merge_or_add_vmap_area(va, &free_vmap_area_root,

					    &free_vmap_area_list);



		if (!va)

			continue;



		if (is_vmalloc_or_module_addr((void *)orig_start))

			kasan_release_vmalloc(orig_start, orig_end,

					      va->va_start, va->va_end);
@@ -3330,6 +3351,7 @@ recovery: 
		orig_end = vas[area]->va_end;

		va = merge_or_add_vmap_area(vas[area], &free_vmap_area_root,

					    &free_vmap_area_list);

		if (va)

			kasan_release_vmalloc(orig_start, orig_end,

				va->va_start, va->va_end);

		vas[area] = NULL;
@@ -3379,6 +3401,7 @@ err_free_shadow: 
		orig_end = vas[area]->va_end;

		va = merge_or_add_vmap_area(vas[area], &free_vmap_area_root,

					    &free_vmap_area_list);

		if (va)

			kasan_release_vmalloc(orig_start, orig_end,

				va->va_start, va->va_end);

		vas[area] = NULL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE