Commit 9c7b4e8a authored Feb 14, 2013 by Russ Dill Committed by Mark Brown Feb 14, 2013

regulator: Fix memory garbage dev_err printout.



commit dd8004af: 'regulator: core: Log when a device causes a voltage
constraint fail', tried to print out some information about the
check consumer min/max uV fixup, however, it uses a garbage pointer
left over from list_for_each_entry leading to boot messages in the
form:

'[    2.079890] <RANDOM ASCII>: Restricting voltage, 3735899821-4294967295uV'

Because it references regulator->dev, it could potentially read memory from
anywhere causing a panic.

This patch instead uses rdev and the updated min/max uV values.

Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent f2e5d078

drivers/regulator/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -200,8 +200,8 @@ static int regulator_check_consumers(struct regulator_dev *rdev,
		}

		if (min_uV > max_uV) {
		dev_err(regulator->dev, "Restricting voltage, %u-%uuV\n",
		regulator->min_uV, regulator->max_uV);
		rdev_err(rdev, "Restricting voltage, %u-%uuV\n",
		min_uV, max_uV);
		return -EINVAL;
		}

Admin message