Commit 9c796ec8 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf hists browser: Use sort__has_sym 



The TUI hist browser had a similar variable has_symbols for the same
purpose.  Let's get rid of the duplication.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1365125198-8334-9-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 8f0f684b

tools/perf/ui/browsers/hists.c

+2 −7
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ struct hist_browser { 
	struct map_symbol   *selection;

	int		     print_seq;

	bool		     show_dso;

	bool		     has_symbols;

};



extern void hist_browser__init_hpp(void);
@@ -1155,10 +1154,6 @@ static struct hist_browser *hist_browser__new(struct hists *hists) 
		browser->b.refresh = hist_browser__refresh;

		browser->b.seek = ui_browser__hists_seek;

		browser->b.use_navkeypressed = true;

		if (sort__mode == SORT_MODE__BRANCH)

			browser->has_symbols = sort_sym_from.list.next != NULL;

		else

			browser->has_symbols = sort_sym.list.next != NULL;

	}



	return browser;
@@ -1386,7 +1381,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, 
			 */

			goto out_free_stack;

		case 'a':

			if (!browser->has_symbols) {

			if (!sort__has_sym) {

				ui_browser__warning(&browser->b, delay_secs * 2,

			"Annotation is only available for symbolic views, "

			"include \"sym*\" in --sort to use it.");
@@ -1485,7 +1480,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, 
			continue;

		}



		if (!browser->has_symbols)

		if (!sort__has_sym)

			goto add_exit_option;



		if (sort__mode == SORT_MODE__BRANCH) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE