Commit 9c72ebef authored Jun 26, 2009 by Borislav Petkov Committed by David S. Miller Jun 26, 2009

ide-cd: handle fragmented packet commands gracefully

There are some devices in the wild that clear the DRQ bit during the
last word of a packet command and therefore could use a "second chance"
for that last word of data to be xferred instead of simply failing the
request. Do that by attempting to suck in those last bytes in PIO mode.

In addition, the ATA_ERR bit has to be cleared for we cannot be sure the
data is valid otherwise.

See http://bugzilla.kernel.org/show_bug.cgi?id=13399

 for details.

Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5e955245

drivers/ide/ide-cd.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -592,9 +592,19 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
		}
		} else if (!blk_pc_request(rq)) {
		ide_cd_request_sense_fixup(drive, cmd);
		/* complain if we still have data left to transfer */

		uptodate = cmd->nleft ? 0 : 1;
		if (uptodate == 0)

		/*
		* suck out the remaining bytes from the drive in an
		* attempt to complete the data xfer. (see BZ#13399)
		*/
		if (!(stat & ATA_ERR) && !uptodate && thislen) {
		ide_pio_bytes(drive, cmd, write, thislen);
		uptodate = cmd->nleft ? 0 : 1;
		}

		if (!uptodate)
		rq->cmd_flags \|= REQ_FAILED;
		}
		goto out_end;

Admin message