stop_machine: Move local variable closer to the usage site in cpu_stop_cpu_callback() (9c6f7e43) · Commits · 戴 / test

This addresses the following compiler warning: kernel/stop_machine.c: In function 'cpu_stop_cpu_callback': kernel/stop_machine.c:297: warning: unused variable 'work' Cc: Tejun Heo <tj@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> LKML-Reference: <tip-@git.kernel.org> Signed-off-by:

Ingo Molnar <mingo@elte.hu>

kernel/stop_machine.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -294,7 +294,6 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
		struct sched_param param = { .sched_priority = MAX_RT_PRIO - 1 };
		unsigned int cpu = (unsigned long)hcpu;
		struct cpu_stopper *stopper = &per_cpu(cpu_stopper, cpu);
		struct cpu_stop_work *work;
		struct task_struct *p;

		switch (action & ~CPU_TASKS_FROZEN) {
		@@ -323,6 +322,9 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
		#ifdef CONFIG_HOTPLUG_CPU
		case CPU_UP_CANCELED:
		case CPU_DEAD:
		{
		struct cpu_stop_work *work;

		/* kill the stopper */
		kthread_stop(stopper->thread);
		/* drain remaining works */
		@@ -335,6 +337,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
		put_task_struct(stopper->thread);
		stopper->thread = NULL;
		break;
		}
		#endif
		}

Admin message