Commit 9c4843ea authored Jun 06, 2011 by Jeff Layton Committed by Steve French Jun 07, 2011

cifs: silence printk when establishing first session on socket



When signing is enabled, the first session that's established on a
socket will cause a printk like this to pop:

    CIFS VFS: Unexpected SMB signature

This is because the key exchange hasn't happened yet, so the signature
field is bogus. Don't try to check the signature on the socket until the
first session has been established. Also, eliminate the specific check
for SMB_COM_NEGOTIATE since this check covers that case too.

Cc: stable@kernel.org
Cc: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent 243e2dd3

fs/cifs/cifsencrypt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -184,7 +184,7 @@ int cifs_verify_signature(struct smb_hdr *cifs_pdu,
		if (cifs_pdu == NULL \|\| server == NULL)
		return -EINVAL;

		if (cifs_pdu->Command == SMB_COM_NEGOTIATE)
		if (!server->session_estab)
		return 0;

		if (cifs_pdu->Command == SMB_COM_LOCKING_ANDX) {

Admin message