Commit 9c37547a authored Aug 31, 2010 by Tejun Heo

workqueue: use zalloc_cpumask_var() for gcwq->mayday_mask



alloc_mayday_mask() was using alloc_cpumask_var() making
gcwq->mayday_mask contain garbage after initialization on
CONFIG_CPUMASK_OFFSTACK=y configurations.  This combined with the
previously fixed GCWQ_DISASSOCIATED initialization bug could make
rescuers fall into infinite loop trying to bind to an offline cpu.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: CAI Qian <caiqian@redhat.com>

parent 477a3c33

kernel/workqueue.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -196,7 +196,7 @@ typedef cpumask_var_t mayday_mask_t;
		cpumask_test_and_set_cpu((cpu), (mask))
		#define mayday_clear_cpu(cpu, mask) cpumask_clear_cpu((cpu), (mask))
		#define for_each_mayday_cpu(cpu, mask) for_each_cpu((cpu), (mask))
		#define alloc_mayday_mask(maskp, gfp) alloc_cpumask_var((maskp), (gfp))
		#define alloc_mayday_mask(maskp, gfp) zalloc_cpumask_var((maskp), (gfp))
		#define free_mayday_mask(mask) free_cpumask_var((mask))
		#else
		typedef unsigned long mayday_mask_t;

Admin message