Commit 9c145c56 authored Jan 29, 2015 by Linus Torvalds

vm: make stack guard page errors return VM_FAULT_SIGSEGV rather than SIGBUS



The stack guard page error case has long incorrectly caused a SIGBUS
rather than a SIGSEGV, but nobody actually noticed until commit
fee7e49d ("mm: propagate error from stack expansion even for guard
page") because that error case was never actually triggered in any
normal situations.

Now that we actually report the error, people noticed the wrong signal
that resulted.  So far, only the test suite of libsigsegv seems to have
actually cared, but there are real applications that use libsigsegv, so
let's not wait for any of those to break.

Reported-and-tested-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Jan Engelhardt <jengelh@inai.de>
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com> # "s390 still compiles and boots"
Cc: linux-arch@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 33692f27

mm/memory.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2632,7 +2632,7 @@ static int do_anonymous_page(struct mm_struct mm, struct vm_area_struct vma,

		/* Check if we need to add a guard page to the stack */
		if (check_stack_guard_page(vma, address) < 0)
		return VM_FAULT_SIGBUS;
		return VM_FAULT_SIGSEGV;

		/* Use the zero-page for reads */
		if (!(flags & FAULT_FLAG_WRITE) && !mm_forbids_zeropage(mm)) {

Admin message