Commit 9bea3f29 authored May 23, 2007 by Florin Malita Committed by Linus Torvalds May 23, 2007

spi: potential memleak in spidev_ioctl



'ioc' should be deallocated if __copy_from_user fails (found by Coverity
- CID 1644).

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6087b2da

drivers/spi/spidev.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -364,6 +364,7 @@ spidev_ioctl(struct inode inode, struct file filp,
		break;
		}
		if (__copy_from_user(ioc, (void __user *)arg, tmp)) {
		kfree(ioc);
		retval = -EFAULT;
		break;
		}

Admin message