Commit 9be3213b authored Mar 13, 2017 by Nicolas Iooss Committed by Masahiro Yamada Mar 22, 2017

gconfig: remove misleading parentheses around a condition



When building the kernel with clang, the compiler complains about the
presence of a condition inside two pairs of parentheses:

    scripts/kconfig/gconf.c:917:19: error: equality comparison with
    extraneous parentheses [-Werror,-Wparentheses-equality]
                    } else if ((col == COL_OPTION)) {
                                ~~~~^~~~~~~~~~~~~
    scripts/kconfig/gconf.c:917:19: note: remove extraneous parentheses
    around the comparison to silence this warning
                    } else if ((col == COL_OPTION)) {
                               ~    ^            ~
    scripts/kconfig/gconf.c:917:19: note: use '=' to turn this equality
    comparison into an assignment
                    } else if ((col == COL_OPTION)) {
                                    ^~
                                    =

Silence this warning by removing a level of parentheses.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

parent 7292ae3d

scripts/kconfig/gconf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -914,7 +914,7 @@ on_treeview2_button_press_event(GtkWidget * widget,
		current = menu;
		display_tree_part();
		gtk_widget_set_sensitive(back_btn, TRUE);
		} else if ((col == COL_OPTION)) {
		} else if (col == COL_OPTION) {
		toggle_sym_value(menu);
		gtk_tree_view_expand_row(view, path, TRUE);
		}

Admin message