Commit 9bde425e authored Jul 22, 2020 by Dan Carpenter Committed by Mauro Carvalho Chehab Aug 06, 2020

media: allegro: fix an error pointer vs NULL check



The allegro_mbox_init() function returns error pointers, it never
returns NULL.

Fixes: 94dc7656 ("media: allegro: rework mbox handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 43663dc4

drivers/staging/media/allegro-dvt/allegro-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2952,7 +2952,7 @@ static int allegro_mcu_hw_init(struct allegro_dev *dev,
		info->mailbox_size);
		dev->mbox_status = allegro_mbox_init(dev, info->mailbox_status,
		info->mailbox_size);
		if (!dev->mbox_command \|\| !dev->mbox_status) {
		if (IS_ERR(dev->mbox_command) \|\| IS_ERR(dev->mbox_status)) {
		v4l2_err(&dev->v4l2_dev,
		"failed to initialize mailboxes\n");
		return -EIO;

Admin message