Commit 9bdda4e9 authored Sep 01, 2018 by Amir Goldstein Committed by Jan Kara Sep 03, 2018

fsnotify: fix ignore mask logic in fsnotify()



Commit 92183a42 ("fsnotify: fix ignore mask logic in
send_to_group()") acknoledges the use case of ignoring an event on
an inode mark, because of an ignore mask on a mount mark of the same
group (i.e. I want to get all events on this file, except for the events
that came from that mount).

This change depends on correctly merging the inode marks and mount marks
group lists, so that the mount mark ignore mask would be tested in
send_to_group(). Alas, the merging of the lists did not take into
account the case where event in question is not in the mask of any of
the mount marks.

To fix this, completely remove the tests for inode and mount event masks
from the lists merging code.

Fixes: 92183a42 ("fsnotify: fix ignore mask logic in send_to_group")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>

parent 60c1f892

fs/notify/fsnotify.c

+3 −10

Original line number	Diff line number	Diff line
		@@ -351,16 +351,9 @@ int fsnotify(struct inode to_tell, __u32 mask, const void data, int data_is,

		iter_info.srcu_idx = srcu_read_lock(&fsnotify_mark_srcu);

		if ((mask & FS_MODIFY) \|\|
		(test_mask & to_tell->i_fsnotify_mask)) {
		iter_info.marks[FSNOTIFY_OBJ_TYPE_INODE] =
		fsnotify_first_mark(&to_tell->i_fsnotify_marks);
		}

		if (mnt && ((mask & FS_MODIFY) \|\|
		(test_mask & mnt->mnt_fsnotify_mask))) {
		iter_info.marks[FSNOTIFY_OBJ_TYPE_INODE] =
		fsnotify_first_mark(&to_tell->i_fsnotify_marks);
		if (mnt) {
		iter_info.marks[FSNOTIFY_OBJ_TYPE_VFSMOUNT] =
		fsnotify_first_mark(&mnt->mnt_fsnotify_marks);
		}

Admin message